Fix builds of lightning-rapid-gossip-sync and lightning-background-processor crates
#3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3289 +/- ##
==========================================
+ Coverage 89.65% 89.91% +0.26%
==========================================
Files 126 126
Lines 102546 104476 +1930
Branches 102546 104476 +1930
==========================================
+ Hits 91935 93941 +2006
+ Misses 7890 7841 -49
+ Partials 2721 2694 -27 ☔ View full report in Codecov by Sentry. |
tnull
force-pushed
the
2024-09-fix-rgs-bp-builds
branch
2 times, most recently
from
feb6f75
to
21353b7
Compare
TheBlueMatt
reviewed
Sep 4, 2024
tnull
force-pushed
the
2024-09-fix-rgs-bp-builds
branch
from
21353b7
to
a3142f7
Compare
tnull
force-pushed
the
2024-09-fix-rgs-bp-builds
branch
from
a3142f7
to
2189253
Compare
|
As discussed elsewhere I now added a commit dropping |
tnull
force-pushed
the
2024-09-fix-rgs-bp-builds
branch
3 times, most recently
from
7ae3a50
to
0e8a736
Compare
|
CI is very sad :/ |
tnull
force-pushed
the
2024-09-fix-rgs-bp-builds
branch
3 times, most recently
from
1b2e18b
to
5adb167
Compare
|
Now added a commit fixing doc generation for |
tnull
force-pushed
the
2024-09-fix-rgs-bp-builds
branch
3 times, most recently
from
8fefd84
to
df6ea28
Compare
|
Feel free to squash imo. |
tnull
force-pushed
the
2024-09-fix-rgs-bp-builds
branch
from
df6ea28
to
f0a94df
Compare
Squashed without further changes. |
TheBlueMatt
previously approved these changes
Sep 17, 2024
|
Oops, looks like fuzzing CI is still trying to pass a |
tnull
force-pushed
the
2024-09-fix-rgs-bp-builds
branch
from
f0a94df
to
212a842
Compare
We previously removed these, leading to failure to build under default features including `std`.
Previously, we would only check the workspace as a whole. This however would mean that we would check/test crates with `lightning`'s default features enabled, allowing failures-to-build under the crates own default features to slip through, if they didn't explicitly enable `lightning/std`, for example. Here, we extend the CI to check the workspace as a whole but then run checks, tests, and doc generation on the workspace members individually, asserting that all of them build even when not built as part of the same workspace as `lightning`.
We drop the `lightning/no-std` feature and just take `hashbrown`,`possiblyrandom` and `libm` as required dependencies.
tnull
force-pushed
the
2024-09-fix-rgs-bp-builds
branch
from
212a842
to
545b037
Compare
Ah, actually not fuzzing, but the Amended and force-pushed with the following changes: diff --git a/ci/check-compiles.sh b/ci/check-compiles.sh
index 7ad9f4df1..a067861fb 100755
--- a/ci/check-compiles.sh
+++ b/ci/check-compiles.sh
@@ -7,4 +7,4 @@ cargo doc
cargo doc --document-private-items
cd fuzz && RUSTFLAGS="--cfg=fuzzing --cfg=secp256k1_fuzz --cfg=hashes_fuzz" cargo check --features=stdin_fuzz
-cd ../lightning && cargo check --no-default-features --features=no-std
+cd ../lightning && cargo check --no-default-features
cd .. && RUSTC_BOOTSTRAP=1 RUSTFLAGS="--cfg=c_bindings" cargo check -Z avoid-dev-deps
diff --git a/lightning-background-processor/Cargo.toml b/lightning-background-processor/Cargo.toml
index d73499fd4..0afc18fdf 100644
--- a/lightning-background-processor/Cargo.toml
+++ b/lightning-background-processor/Cargo.toml
@@ -16,5 +16,5 @@ rustdoc-args = ["--cfg", "docsrs"]
[features]
futures = [ ]
-std = ["lightning/std", "lightning-rapid-gossip-sync/std"]
+std = ["lightning/std", "bitcoin-io/std", "bitcoin_hashes/std"]
default = ["std"]
@@ -22,4 +22,6 @@ default = ["std"]
[dependencies]
bitcoin = { version = "0.32.2", default-features = false }
+bitcoin_hashes = { version = "0.14.0", default-features = false }
+bitcoin-io = { version = "0.1.2", default-features = false }
lightning = { version = "0.0.124", path = "../lightning", default-features = false }
lightning-rapid-gossip-sync = { version = "0.0.124", path = "../lightning-rapid-gossip-sync", default-features = false } |
TheBlueMatt
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would only check the builds for the workspace as a whole. This however would mean that we would check/test crates with
lightning's default features enabled, allowing failures-to-build under the crates own default features to slip through, if they didn't explicitly enablelightning/std, for example.Here, we fix the regressions in the builds of the
lightning-rapid-gossip-syncandlightning-background-processorcrates, and extend the CI to run checks, tests, and doc generation on the workspace members individually, asserting that all of them build even when not built as part of the same workspace aslightning.